Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move Animated to @react-native/animated #35467

Closed
wants to merge 1 commit into from
Closed

feat: Move Animated to @react-native/animated #35467

wants to merge 1 commit into from

Conversation

gabrieldonadel
Copy link
Collaborator

@gabrieldonadel gabrieldonadel commented Nov 24, 2022 •
edited
Loading

Summary

This PR moves the Animated module to a separate package called @react-native/animated located under packages/animated as proposed on #35263

Changelog

[General] [Changed] - Move Animated to @react-native/animated package

Test Plan

  1. Open the RNTester app and navigate to Animated page
  2. Test animated functionalities through the many sections
Screen.Recording.2022-11-25.at.01.46.36.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 24, 2022
@gabrieldonadel gabrieldonadel force-pushed the feat/add-animated-package branch from 7c0019d to e2d9c39 Compare November 25, 2022 03:57
@github-actions
Copy link

github-actions bot commented Nov 25, 2022 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 20ea260

@gabrieldonadel gabrieldonadel force-pushed the feat/add-animated-package branch 8 times, most recently from fea3770 to 9c3552f Compare November 25, 2022 05:03
@gabrieldonadel gabrieldonadel marked this pull request as ready for review November 25, 2022 05:03
@gabrieldonadel gabrieldonadel force-pushed the feat/add-animated-package branch 3 times, most recently from 190672f to a9a1df1 Compare November 30, 2022 12:26
@gabrieldonadel gabrieldonadel force-pushed the feat/add-animated-package branch 2 times, most recently from 2c2393a to 58cb383 Compare December 4, 2022 17:46
@gabrieldonadel gabrieldonadel force-pushed the feat/add-animated-package branch 2 times, most recently from ed749c3 to 0bcf394 Compare December 20, 2022 21:15
@gabrieldonadel gabrieldonadel force-pushed the feat/add-animated-package branch from 0bcf394 to 20ea260 Compare December 20, 2022 21:21
@necolas
Copy link
Contributor

necolas commented Mar 28, 2023

Looks like we need to update this because of the monorepo moves

@gabrieldonadel
Copy link
Collaborator Author

Looks like we need to update this because of the monorepo moves

To be honest there are so many conflicts with the new monorepo structure that I'll probably just start this from scratch and force push a new commit

@necolas
Copy link
Contributor

necolas commented Apr 11, 2023 •
edited
Loading

An issue that I recently encountered with the RN Animated is that React.useLayoutEffect in useAnimatedProps causes errors during SSR on Web. IIRC there is a proposal for React.useLayoutEffect to change to a noop during SSR, but if that doesn't land soon, then we'd need to use a user-space useLayoutEffect that avoids the issue.

necolas/react-native-web@338cce1

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 20, 2023
@gabrieldonadel gabrieldonadel mentioned this pull request Oct 29, 2023
Open
13 tasks
@DylanTet
Copy link

Am i able to just fetch from this PR to set my branch from this?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieldonadel @necolas @DylanTet @facebook-github-bot